Added command line and environment to the hermit entry parameters #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jounathaen
force-pushed
the
uhyve-argenv
branch
from
b4943c3
to
65f9c1a
Compare
mkroening
requested changes
Sep 19, 2024
There was a problem hiding this comment.
As we are slowly moving away from raw structs and towards device trees (#5), this should be done via the already available HardwareInfo::device_tree.
I think /chosen/bootargs would fit quite well:
chosen {
bootargs = "env=RUST_LOG=info env=FOO=bar [OTHER_KERNEL_ARGS] -- [APP_ARGS]";
}
|
I think that is a good approach, but it should be considered that we potentially pass hundreds of environment variables. As changing uhyve to use device trees is a bigger project, maybe we can still go with this approach as an intermediate step? (To at get rid of the hypercall first) |
|
I'd like to avoid having to do a entry version jump for this. I think gradual migration should be easy. I'll open a draft PR tomorrow for initial device tree support for Uhyve, just for bootargs. |
|
Superseded by hermit-os/uhyve#758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get rid of the hypercalls in uhyve just to retrieve the env and argv. I think it makes sense to add them to the boot information, as they are available at boot time anyway.
(Once implemented in uhyve and hermit, this would solve hermit-os/uhyve#35)